[prototype] Remove _FT aliases from functional#6983
Merged
datumbox merged 3 commits intopytorch:mainfrom Nov 28, 2022
Merged
Conversation
31 tasks
datumbox
changed the title
_FT usages from functional_FT aliases from functional
pmeier
approved these changes
Nov 28, 2022
Contributor
pmeier
left a comment
pmeier
left a comment
There was a problem hiding this comment.
One minor nit otherwise LGTM!
facebook-github-bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
Summary: * Remove `_FT` usages from functional * Update error messages Reviewed By: YosuaMichael Differential Revision: D41648544 fbshipit-source-id: 096f5fa48cb1c320f8a23a25d2b048b268326746
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6818
This PR eliminates the use of
_FTaliases from prototype functional by porting over the last 3 remaining kernels. There might be some trivial speed improvements due to the elimination of unnecessary checks but nothing worth measuring IMO.cc @vfdev-5 @bjuncek @pmeier